Re: [PATCH v5 05/11] iio: adc: ad4170: Add digital filter and sample frequency config support

From: David Lechner
Date: Mon Jun 16 2025 - 16:53:24 EST


On 6/10/25 3:32 PM, Marcelo Schmitt wrote:
> Add support for sinc3, sinc5, and averaged sinc5 digital filters along with
> sample frequency configuration.

Wouldn't mind having a sentence here explaining why post filter control
was omitted.

>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> ---

...

>
> +static const char * const ad4170_filt_names[] = {
> + [AD4170_SINC5_AVG] = "sinc5+avg",

Do we need to document this as possible type in
Documentation/ABI/testing/sysfs-bus-iio?

> + [AD4170_SINC5] = "sinc5",
> + [AD4170_SINC3] = "sinc3",
> +};
> +