Re: [PATCH] Various improvements on clock abstractions

From: Miguel Ojeda
Date: Mon Jun 16 2025 - 16:40:41 EST


On Mon, Jun 16, 2025 at 10:01 PM onur-ozkan <work@xxxxxxxxxxxxx> wrote:
>
> Signed-off-by: onur-ozkan <work@xxxxxxxxxxxxx>

Should this be "Onur Özkan"? Apologies if not -- I am just asking
because the SoB typically uses the full name as usually written, and I
saw it in Zulip spelled differently.

Cc'ing Viresh, since he introduced the file.

On the changes themselves, the `const fn` one seems obvious.

The constants one is OK, though we could perhaps have a `units.h`
equivalent eventually.

The `map_or` is up to style, though I am not sure why you say "nested
if-else blocks" in the commit message, i.e. what is nested?

(By the way, this could (or not) have been split into different
patches -- it is up to the maintainers/reviewers, and it depends on
how complex a given patch is and other factors, but I thought I would
mention it just in case you thought it needed to be one.)

Thanks!

Cheers,
Miguel