Re: [RFC PATCH] ACPI / sysfs: Replace deprecated strcpy() with strscpy()
From: Brahmajit Das
Date: Mon Jun 16 2025 - 13:53:01 EST
On 16.06.2025 23:17, Brahmajit Das wrote:
...
> ---
> drivers/acpi/sysfs.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/sysfs.c b/drivers/acpi/sysfs.c
> index a48ebbf768f9..4005c9faf14f 100644
> --- a/drivers/acpi/sysfs.c
> +++ b/drivers/acpi/sysfs.c
> @@ -181,10 +181,9 @@ static int param_set_trace_method_name(const char *val,
>
> /* This is a hack. We can't kmalloc in early boot. */
> if (is_abs_path)
> - strcpy(trace_method_name, val);
> + strscpy(trace_method_name, val);
> else {
> - trace_method_name[0] = '\\';
> - strcpy(trace_method_name+1, val);
> + scnprintf(trace_method_name, sizeof(trace_method_name), "%c%s", '\\', val);
Maybe something like would be better
- trace_method_name[0] = '\\';
- strcpy(trace_method_name+1, val);
+ scnprintf(trace_method_name, sizeof(trace_method_name+1), "%c%s", '\\', val);
--
Regards,
listout