Re: [PATCH] KVM: arm64: nv: Fix s_cpu_if->vgic_lr[] indexing in vgic_v3_put_nested()

From: Marc Zyngier
Date: Mon Jun 16 2025 - 13:01:13 EST


On Mon, 16 Jun 2025 15:34:58 +0100,
Wei-Lin Chang <r09922117@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jun 16, 2025 at 11:54:57AM +0100, Marc Zyngier wrote:
>
> > +static u64 translate_lr_hw_bit(struct kvm_vcpu *vcpu, u64 lr)
>
> I believe translate_lr_pintid() better describes what this function is
> doing.

Ah, you too noticed that I am terrible at naming things? ;-)

Agreed, this is a better name, and I'll gladly apply your suggestion.

>
> For everything else, I don't spot any issues after review.
>
> Reviewed-by: Wei-Lin Chang <r09922117@xxxxxxxxxxxxxxx>

Thanks again!

M.

--
Without deviation from the norm, progress is not possible.