Re: [PATCH v5] drm/bridge: ti-sn65dsi86: Add HPD for DisplayPort connector type

[Doug Anderson]

Hi,

On Mon, Jun 16, 2025 at 2:32 AM Jayesh Choudhary <j-choudhary@xxxxxx> wrote:
>
> @@ -1220,6 +1231,27 @@ static void ti_sn65dsi86_debugfs_init(struct drm_bridge *bridge, struct dentry *
>         debugfs_create_file("status", 0600, debugfs, pdata, &status_fops);
>  }
>
> +static void ti_sn_bridge_hpd_enable(struct drm_bridge *bridge)
> +{
> +       struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge);
> +
> +       /*
> +        * Device needs to be powered on before reading the HPD state
> +        * for reliable hpd detection in ti_sn_bridge_detect() due to
> +        * the high debounce time.
> +        */
> +
> +       pm_runtime_get_sync(pdata->dev);
> +}
> +
> +static void ti_sn_bridge_hpd_disable(struct drm_bridge *bridge)
> +{
> +       struct ti_sn65dsi86 *pdata = bridge_to_ti_sn65dsi86(bridge);
> +
> +       pm_runtime_mark_last_busy(pdata->dev);
> +       pm_runtime_put_autosuspend(pdata->dev);

nit: you don't need the pm_runtime_mark_last_busy() here, do you? Just
call pm_runtime_put_autosuspend().

Aside from the nit, this looks reasonable to me now.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>