Re: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685

[Guenter Roeck]

On 6/10/25 03:25, Chiang Brian wrote:
...
> @@ -263,6 +282,10 @@ static int tps53679_probe(struct i2c_client *client)
>   		info->identify = tps53681_identify;
>   		info->read_word_data = tps53681_read_word_data;
>   		break;
> +	case tps53685:
> +	    info->pages = TPS53679_PAGE_NUM;
> +	    info->identify = tps53685_identify;
> +		break;

0-day rightfully complains about the bad alignment above.

If you want this patch to be applied for the next kernel release,
I would suggest to copy the hardware monitoring list on the first patch
of the series. Without it, I get

WARNING: DT compatible string "ti,tps53685" appears un-documented -- check ./Documentation/devicetree/bindings/
#296: FILE: drivers/hwmon/pmbus/tps53679.c:316:
+	{.compatible = "ti,tps53685", .data = (void *)tps53685},

Since I am not copied on the first patch of the series, that patch has to be applied
through a different maintainer tree, and I have to wait until that is the case.
Not that I understand the logic behind it, but I mentioned that before, so I assume
this is on purpose.

Guenter