Re: [PATCH RESEND] firmware: cs_dsp: Remove unused struct list_head from cs_dsp_coeff_ctl

From: Mark Brown
Date: Mon Jun 16 2025 - 11:51:07 EST


On Mon, 16 Jun 2025 11:30:52 +0100, Richard Fitzgerald wrote:
> Remove two unused pointers from struct cs_dsp_coeff_ctl by taking the
> struct list_head out of struct cs_dsp_alg_region. On a x86_64 build
> this saves 16 bytes per control.
>
> Each cs_dsp_coeff_ctl instance needs to keep information about the
> algorithm region it refers to. This is done by embedding an instance
> of struct cs_dsp_alg_region. But cs_dsp_alg_region was also used to
> store entries in a list of algorithm regions, and so had a struct
> list_head object for that purpose. This list_head object is not used
> with the embedded object in struct cs_dsp_alg_region so was just
> wasted bytes.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] firmware: cs_dsp: Remove unused struct list_head from cs_dsp_coeff_ctl
commit: e7af416aebb36e6681b9c6950d0f6352aee7c084

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark