Re: [PATCH 07/14] xfs: ifdef out unused xfs_attr events

[Steven Rostedt]

On Mon, 16 Jun 2025 07:28:10 +0200
Christoph Hellwig <hch@xxxxxx> wrote:

> On Thu, Jun 12, 2025 at 05:24:12PM -0400, Steven Rostedt wrote:
> > From: Steven Rostedt <rostedt@xxxxxxxxxxx>
> > 
> > Trace events can take up to 5K in memory for text and meta data per event
> > regardless if they are used or not, so they should not be defined when not
> > used. The events xfs_attr_fillstate and xfs_attr_refillstate are only
> > called in code that is #ifdef out and exists only for future reference.
> > 
> > Ifdef out the events that go with that code and add a comment mentioning
> > the other code.  
> 
> Just drop them entirely, which is what the code using them should
> have done as well.  We can always triviall bring back code from
> git history.

OK. But I'll only send a patch to delete the trace events. I'll let
someone else remove the actual code.

-- Steve