Re: [PATCH net v1] net: netmem: fix skb_ensure_writable with unreadable skbs
From: Stanislav Fomichev
Date: Mon Jun 16 2025 - 10:39:14 EST
On 06/15, Mina Almasry wrote:
> skb_ensure_writable should succeed when it's trying to write to the
> header of the unreadable skbs, so it doesn't need an unconditional
> skb_frags_readable check. The preceding pskb_may_pull() call will
> succeed if write_len is within the head and fail if we're trying to
> write to the unreadable payload, so we don't need an additional check.
>
> Removing this check restores DSCP functionality with unreadable skbs as
> it's called from dscp_tg.
Can you share more info on which use-case (or which call sites) you're
trying to fix?