Re: [PATCH v2 8/9] media: core: export v4l2_compat_translate_cmd()
From: Hans de Goede
Date: Mon Jun 16 2025 - 10:14:57 EST
Hi Ricardo,
On 2-Jun-25 15:06, Ricardo Ribalda wrote:
> v4l2_compat_translate_cmd() can be useful for drivers to convert between
> the VIDIOC_*32 and VIDIOC_ defines.
>
> The VIDIOC_*32 defines are not accessible by the drivers, they live in
> v4l2-compat-ioctl32.c.
>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@xxxxxxxxxx>
Regards,
Hans
> ---
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> index 8c07400bd280dea5d2e66e2759658c423bcd3866..ced4892b42597d605887b7c6a14373e3922f7bc6 100644
> --- a/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> +++ b/drivers/media/v4l2-core/v4l2-compat-ioctl32.c
> @@ -929,6 +929,7 @@ unsigned int v4l2_compat_translate_cmd(unsigned int cmd)
> }
> return cmd;
> }
> +EXPORT_SYMBOL_GPL(v4l2_compat_translate_cmd);
>
> int v4l2_compat_get_user(void __user *arg, void *parg, unsigned int cmd)
> {
>