Re: [PATCH net-next v2] net: bcmgenet: update PHY power down

From: Simon Horman
Date: Mon Jun 16 2025 - 10:11:43 EST


On Fri, Jun 13, 2025 at 07:58:16PM -0700, Florian Fainelli wrote:
> From: Doug Berger <opendmb@xxxxxxxxx>
>
> The disable sequence in bcmgenet_phy_power_set() is updated to
> match the inverse sequence and timing (and spacing) of the
> enable sequence. This ensures that LEDs driven by the GENET IP
> are disabled when the GPHY is powered down.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Thanks Doug and Florian,

I agree that the code does what it says on the wrapper.
Although I have no way to test it's effect on real hardware.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>