Re: [PATCH 0/2] media: uvcvideo: Enable keep-sorted

[Ricardo Ribalda]

Hi Hans

On Mon, 16 Jun 2025 at 15:05, Hans de Goede <hansg@xxxxxxxxxx> wrote:
>
> Hi Ricardo,
>
> On 29-Apr-25 15:47, Ricardo Ribalda wrote:
> > When committers contribute quirks to the uvc driver, they usually add
> > them out of order.
> >
> > We can automatically validate that their follow our guidelines with the
> > use of keep-sorted.
> >
> > This patchset adds support for keep-sorted in the uvc driver. The two
> > patches can be squashed if needed.
> >
> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
>
> I've no objections against these 2 patches, but these need to be
> rebased on top of the latest uvc/for-next. Can you send out a new
> version please ?

I was waiting for HansV to say that keep-sorted was useful and then
add it to the CI.

Right now it is probably just useful for the Makefiles and uvc.

>
> Also for patch 2/2 can we not just add the 2 keep-sorted headers
> and then actually run keep-sorted to auto-fix things ?

Do you mean removing the annotation after running keep-sorted?

We can do that, but we will be unsorted again in the future after N
patches unless we add it to CI.

If we do not handle this automatically I do not think that there is
much point on this series.


Thanks for looking into it anyway :)

>
> Or can it not auto-fix ?
>
> Regards,
>
> Hans
>
>
>
> > ---
> > Ricardo Ribalda (2):
> >       media: uvcvideo: Rewrite uvc_ids for keep-sorted.
> >       media: uvcvideo: Add keep-sorted statement and sort uvc_ids
> >
> >  drivers/media/usb/uvc/uvc_driver.c | 660 +++++++++++++++++++++++--------------
> >  1 file changed, 409 insertions(+), 251 deletions(-)
> > ---
> > base-commit: 398a1b33f1479af35ca915c5efc9b00d6204f8fa
> > change-id: 20250429-keep-sorted-2ac6f4796726
> >
> > Best regards,
>


-- 
Ricardo Ribalda