Re: [PATCH v8 0/2] riscv: pwm: sophgo: add pwm support for CV1800
From: Uwe Kleine-König
Date: Mon Jun 16 2025 - 09:05:26 EST
Hello,
On Tue, May 27, 2025 at 06:43:06AM +0800, Inochi Amaoto wrote:
> On Mon, May 26, 2025 at 06:31:42PM +0200, Uwe Kleine-König wrote:
> > On Fri, May 09, 2025 at 08:14:57PM +0800, Inochi Amaoto wrote:
> > > On Fri, May 09, 2025 at 11:45:42AM +0200, Thomas Bonnefille wrote:
> > > > The Sophgo CV1800 chip provides a set of four independent
> > > > PWM channel outputs.
> > > > This series adds PWM controller support for Sophgo cv1800.
> > > >
> > > > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> > > > [Thomas since v8]
> > > > Signed-off-by: Thomas Bonnefille <thomas.bonnefille@xxxxxxxxxxx>
> > > > ---
> > >
> > > As now we have pwm support for SG2042, I suggest sharing driver code and
> > > binding file with SG2042.
> >
> > How does the two relate? Is CV1800 the same as SG2042? I'd like to know
> > before I spend time reviewing a driver that is better spent elsewhere.
> >
>
> IIRC the pwm SG2044 is based on it on CV1800. And they both share some
> common logic with SG2042, like setting PERIOD register. So I request a
> merge for it.
To make this explict: Without having looked into the details, I agree
and so will discard this patch set from the set of waiting patches in
patchwork.
Best regards
Uwe
Attachment:
signature.asc
Description: PGP signature