Re: [PATCH v3] PCI/pwrctrl: Move pci_pwrctrl_create_device() definition to drivers/pci/pwrctrl/

From: Manivannan Sadhasivam
Date: Mon Jun 16 2025 - 08:38:14 EST


On Mon, Jun 16, 2025 at 08:21:20PM +0800, kernel test robot wrote:
> Hi Manivannan,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on pci/next]
> [also build test ERROR on pci/for-linus linus/master v6.16-rc2 next-20250616]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam/PCI-pwrctrl-Move-pci_pwrctrl_create_device-definition-to-drivers-pci-pwrctrl/20250616-133314
> base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
> patch link: https://lore.kernel.org/r/20250616053209.13045-1-mani%40kernel.org
> patch subject: [PATCH v3] PCI/pwrctrl: Move pci_pwrctrl_create_device() definition to drivers/pci/pwrctrl/
> config: i386-buildonly-randconfig-001-20250616 (https://download.01.org/0day-ci/archive/20250616/202506162013.go7YyNYL-lkp@xxxxxxxxx/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250616/202506162013.go7YyNYL-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506162013.go7YyNYL-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> ld: drivers/pci/probe.o: in function `pci_scan_single_device':
> >> probe.c:(.text+0x2400): undefined reference to `pci_pwrctrl_create_device'

Hmm, so we cannot have a built-in driver depend on a module...

Bartosz, should we make CONFIG_PCI_PWRCTRL bool then? We can still allow the
individual pwrctrl drivers be tristate.

- Mani

--
மணிவண்ணன் சதாசிவம்