Re: [PATCH v10 2/5] rust: Rename AlwaysRefCounted to RefCounted
From: Alice Ryhl
Date: Mon Jun 16 2025 - 08:14:11 EST
On Mon, Jun 16, 2025 at 1:56 PM Oliver Mangold <oliver.mangold@xxxxx> wrote:
>
> On 250502 1132, Alice Ryhl wrote:
> > On Fri, May 02, 2025 at 09:02:37AM +0000, Oliver Mangold wrote:
> > > AlwaysRefCounted will become a marker trait to indicate that it is allowed
> > > to obtain an ARef<T> from a `&T`, which cannot be allowed for types which
> > > are also Ownable.
> > >
> > > Signed-off-by: Oliver Mangold <oliver.mangold@xxxxx>
> > > Suggested-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> >
> > > // SAFETY: All instances of `Request<T>` are reference counted. This
> > > -// implementation of `AlwaysRefCounted` ensure that increments to the ref count
> > > +// implementation of `RefCounted` ensure that increments to the ref count
> > > // keeps the object alive in memory at least until a matching reference count
> > > // decrement is executed.
> >
> > It looks like "keeps" now fits on the previous line. I would reflow all
> > text in this patch.
>
> Say, this means you have a tool to do that automatically for you? I'm doing
> it by hand currently.
In vim you can do it by selecting the text and typing gq.
Alice