Re: [PATCH v2 1/2] thermal: intel: int340x: Add throttling control interface to PTC

[Rafael J. Wysocki]

On Mon, Jun 16, 2025 at 2:47 AM Zhang, Rui <rui.zhang@xxxxxxxxx> wrote:
>
> On Fri, 2025-06-13 at 14:49 -0700, Srinivas Pandruvada wrote:
> > Firmware-based thermal temperature control loops may aggressively
> > throttle performance to prevent temperature overshoots relative to the
> > defined target temperature. This can negatively impact performance.
> > User
> > space may prefer to prioritize performance, even if it results in
> > temperature overshoots with in acceptable range.
> >
> > For example, user space might tolerate temperature overshoots when the
> > device is placed on a desk, as opposed to when it's on a lap. To
> > accommodate such scenarios, an optional attribute is provided to
> > specify
> > a tolerance level for temperature overshoots while maintaining
> > acceptable
> > performance.
> >
> > Attribute:
> > thermal_tolerance:
>
> yeah, this is much better to me.
>
> >  This attribute ranges from 0 to 7, where 0 represents
> > the most aggressive control to avoid any temperature overshoots, and 7
> > represents a more graceful approach, favoring performance even at the
> > expense of temperature overshoots.
> > Note: This level may not scale linearly. For example, a value of 3 does
> > not
> > necessarily imply a 50% improvement in performance compared to a value
> > of
> > 0.
> >
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Zhang Rui <rui.zhang@xxxxxxxxx>

Applied along with the [2/2] as 6.17 material, thanks!