Re: [PATCH v12 3/5] rust: add bitmap API.

[Alice Ryhl]

On Wed, Jun 11, 2025 at 9:48 PM Burak Emir <bqe@xxxxxxxxxx> wrote:
> +impl core::ops::DerefMut for Bitmap {
> +    fn deref_mut(&mut self) -> &mut CBitmap {
> +        let ptr = if self.nbits <= bindings::BITS_PER_LONG as _ {
> +            // SAFETY: Bitmap is represented inline.
> +            unsafe { core::ptr::addr_of_mut!(self.repr.bitmap) }
> +        } else {
> +            // SAFETY: Bitmap is represented as array of `unsigned long`.
> +            unsafe { self.repr.ptr.as_mut() }

Nit: You want NonNull::as_mut_ptr() here.

Alice