Re: [cocci] [PATCH v4 2/5] arm64: tlb: Convert the opencoded field modify

[Luo Jie]

On 6/13/2025 4:15 AM, Markus Elfring wrote:
> I see further refinement possibilities for such a change description.
>
>
> > Replace below code with the wrapper FIELD_MODIFY(MASK, &reg, val)
> > - reg &= ~MASK;
> > - reg |= FIELD_PREP(MASK, val);
>
> * How do you think about to omit leading minus characters?
>
> * Subsequent blank line?
>
>
> > More information about semantic patching is available at
> > http://coccinelle.lip6.fr/
>
> I suggest to omit this information here (and in similar patches).
>
> Regards,
> Markus

Thank you for your suggestions. The current commit message was generated
by the following patch mode command:
```
make coccicheck MODE=patch 
COCCI=scripts/coccinelle/misc/field_modify.cocci V=1
```
However, as I understand, the discussion on the ARM patches (between
Russel/Marc/Yury) has concluded that the ARM arch changes may not be
adding value over the current code, so I will drop the ARM patches
in the next version.

I will review the generated message to improve the formatting as you
suggested, the next time I use it.