Re: [PATCH net-next 2/4] net: spacemit: Add K1 Ethernet MAC

[Vivian Wang]

Hi Russell,

Thanks for the review.

On 6/16/25 14:33, Russell King (Oracle) wrote:
> On Fri, Jun 13, 2025 at 10:15:08AM +0800, Vivian Wang wrote:
>> +config SPACEMIT_K1_EMAC
>> +	tristate "SpacemiT K1 Ethernet MAC driver"
>> +	depends on ARCH_SPACEMIT || COMPILE_TEST
>> +	depends on MFD_SYSCON
>> +	depends on OF
>> +	default m if ARCH_SPACEMIT
>> +	select PHYLIB
> This driver uses phylib...
>
>> +#include <linux/phy.h>
>> +#include <linux/phylink.h>
> but includes phylink's header file? Does it use anything from this
> header?

Thanks for the suggestion. I have misunderstood the purposes of some of
the header files. I will clean up #include lines in next version.

Regards,
Vivian "dramforever" Wang