Re: [PATCH] mfd: rohm-bd71828: Constify some structures

From: Matti Vaittinen
Date: Mon Jun 16 2025 - 01:59:43 EST


On 15/06/2025 19:32, Christophe JAILLET wrote:
Several structures are not modified in this driver. Constifying them moves
some data to a read-only section, so increases overall security, especially
when the structure holds some function pointers. This is the case for
'gpio_keys_platform_data' and 'mfd_cell'.

On a x86_64, with allmodconfig:
Before:
======
text data bss dec hex filename
18161 14112 192 32465 7ed1 drivers/mfd/rohm-bd71828.o

After:
=====
text data bss dec hex filename
22897 9376 192 32465 7ed1 drivers/mfd/rohm-bd71828.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

Thanks!