Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures

[Kent Overstreet]

On Mon, Jun 16, 2025 at 04:13:55AM +0100, Matthew Wilcox wrote:
> On Mon, Jun 16, 2025 at 10:29:17AM +0800, Hao Ge wrote:
> > +++ b/mm/Kconfig
> > @@ -929,6 +929,10 @@ config ARCH_SUPPORTS_PUD_PFNMAP
> >  	def_bool y
> >  	depends on ARCH_SUPPORTS_HUGE_PFNMAP && HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD
> >  
> > +# s390 and alpha should be enabled,see comments for DECLARE_PER_CPU_SECTION
> 
> This comment is inappropriate and should be removed.

Inappropriate? That's not a word I'm accustomed to hearing as an
engineering justification.

It's referring the reader to context they might want to know about, and
other comments they might want to read. Looks like a good comment to me,
if perhaps a bit terse.