Re: [PATCH v11 0/6] rust: reduce `as` casts, enable related lints

[Tamir Duberstein]

On Fri, Jun 13, 2025 at 2:14 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Wed, Jun 11, 2025 at 12:23 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > This series depends on "rust: retain pointer mut-ness in
> > `container_of!`"[1].
>
> Not anymore! :)
>
> > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>
>
> Thanks for rebasing, Tamir, I appreciate it.
>
> This has a bunch of hits in configfs, cpufreq and Nova [1]. I guess
> you built without those enabled.
>
> Could you please fix those? Since this affects other maintainers that
> we need to ask the Acked-by to, let's try to at least give them the
> final state.

Oops, I missed this email! I will send v12 shortly with these fixed.
Is there an easy way to enable all the relevant rust configs?

>
> Thanks!
>
> Cheers,
> Miguel
>
> [1]
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:429:9
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:467:9
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:479:9
>
> warning: `as` casting between raw pointers without changing their constness
>    --> rust/kernel/configfs.rs:564:48
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:721:39
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:764:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:783:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:764:35
>
> warning: reference as raw pointer
>    --> rust/kernel/configfs.rs:783:35
>
> warning: using `as _` conversion
>    --> rust/kernel/cpufreq.rs:650:45
>
> warning: `as` casting between raw pointers without changing their constness
>    --> rust/kernel/cpufreq.rs:650:45
>
> warning: using `as _` conversion
>   --> drivers/gpu/nova-core/driver.rs:22:64
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>    --> drivers/gpu/nova-core/regs/macros.rs:267:26
>
> warning: casts from `u8` to `u32` can be expressed infallibly using `From`
>   --> drivers/gpu/nova-core/regs.rs:35:65