Re: [PATCH v3 4/4] rust: str: implement `Borrow` and `BorrowMut` for `CString`

From: Alexandre Courbot
Date: Sun Jun 15 2025 - 09:48:26 EST


On Sun Jun 15, 2025 at 10:15 PM JST, Miguel Ojeda wrote:
> On Sun, Jun 15, 2025 at 2:37 PM Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>>
>> +/// // Borrowed from `str_data`.
>> +/// let foo_borrowed = Foo(unsafe { CStr::from_bytes_with_nul_unchecked_mut(&mut str_data) });
>
> We will need a `// SAFETY:` comment -- Clippy should complain.

I thought I could get away with it since it is in a test, and clippy
does not seem to complain about it, but...

>
> Or to add a safe `from_bytes_with_nul_mut`, I guess.

... as penance (and for symmetry with `from_bytes_with_nul`), let me
implement that so we don't need a safety block at all. :)