Re: [PATCH net-next v13 07/13] net: pse-pd: Add support for budget evaluation strategies

[Jakub Kicinski]

On Tue, 10 Jun 2025 10:11:41 +0200 Kory Maincent wrote:
> +static bool
> +pse_pi_is_admin_enable_not_applied(struct pse_controller_dev *pcdev,
> +				   int id)

the only caller of this function seems to negate the return value:

drivers/net/pse-pd/pse_core.c:369:              if (!pse_pi_is_admin_enable_not_applied(pcdev, i))

let's avoid the double negation ?

> +{
> +	int ret;
> +
> +	/* PI not enabled or nothing is plugged */
> +	if (!pcdev->pi[id].admin_state_enabled ||
> +	    !pcdev->pi[id].isr_pd_detected)
> +		return false;
> +
> +	ret = pse_pi_is_hw_enabled(pcdev, id);
> +	/* PSE PI is already enabled at hardware level */
> +	if (ret == 1)
> +		return false;
> +
> +	return true;
> +}

> +static int pse_disable_pi_pol(struct pse_controller_dev *pcdev, int id)
> +{
> +	unsigned long notifs = ETHTOOL_PSE_EVENT_OVER_BUDGET;
> +	struct pse_ntf ntf = {};
> +	int ret;
> +
> +	dev_dbg(pcdev->dev, "Disabling PI %d to free power budget\n", id);
> +
> +	NL_SET_ERR_MSG_FMT(&ntf.extack,
> +			   "Disabling PI %d to free power budget", id);

You so dutifully fill in this extack but it doesn't go anywhere.
Extacks can only be attached to NLMSG_ERROR and NLMSG_DONE
control messages. You can use the extack infra for the formatting,
but you need to add a string attribute to the notification message
to actually expose it to the user.