Re: [PATCH v5 1/3] iio: accel: sca3000: replace error_ret labels by simple returns

From: Andrew Ijano
Date: Sat Jun 14 2025 - 15:13:06 EST


On Thu, Jun 12, 2025 at 4:41 AM Nuno Sá <noname.nuno@xxxxxxxxx> wrote:
>
...
> >
> > Code looks good. But since you're doing this you could cleanup some of the switch()
> > cases. Some return in every case statement while other don't (even think I saw one
> > one place where 'return' in the end was not needed). IIRC, there's preference for
> > returning in place.
> >
>
> I see the above could be a bit cumbersome in cases there's locking (which get's
> cleaned up in patch 3). So, nevermind the above. If there's any leftover, you can
> send a follow up patch or introduce a new patch if you need to re-spin.
>
Great! That's the idea, I addressed these cases in patch #3, but I'll
double check if there is any leftover!

Thanks,
Andrew