Re: [PATCH v9 03/10] clk: qcom: camcc-qcs615: Add QCS615 camera clock controller driver

From: Konrad Dybcio
Date: Sat Jun 14 2025 - 15:08:10 EST


On 6/12/25 11:55 AM, Taniya Das wrote:
> Add support for the camera clock controller for camera clients to
> be able to request for camcc clocks on QCS615 platform.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> ---

[...]

> +static int cam_cc_qcs615_probe(struct platform_device *pdev)
> +{
> + struct regmap *regmap;
> +
> + regmap = qcom_cc_map(pdev, &cam_cc_qcs615_desc);
> + if (IS_ERR(regmap))
> + return PTR_ERR(regmap);
> +
> + clk_alpha_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config);
> + clk_alpha_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config);
> + clk_alpha_pll_configure(&cam_cc_pll2, regmap, &cam_cc_pll2_config);
> + clk_alpha_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config);

Please convert to use Jagadeesh's recent helpers

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad