Re: [PATCH 2/2] scsi: mpi3mr: Add initialization for ATTO 24Gb SAS HBAs
From: kernel test robot
Date: Sat Jun 14 2025 - 08:51:05 EST
Hi Steve,
kernel test robot noticed the following build warnings:
[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.16-rc1 next-20250613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steve-Siwinski/scsi-mpi3mr-Add-initialization-for-ATTO-24Gb-SAS-HBAs/20250614-043438
base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link: https://lore.kernel.org/r/20250613202941.62114-2-ssiwinski%40atto.com
patch subject: [PATCH 2/2] scsi: mpi3mr: Add initialization for ATTO 24Gb SAS HBAs
config: x86_64-buildonly-randconfig-002-20250614 (https://download.01.org/0day-ci/archive/20250614/202506142037.j39pVyE8-lkp@xxxxxxxxx/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250614/202506142037.j39pVyE8-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506142037.j39pVyE8-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/scsi/mpi3mr/mpi3mr_fw.c:1644:47: warning: variable 'scratch_pad0' set but not used [-Wunused-but-set-variable]
1644 | u32 host_diagnostic, ioc_status, ioc_config, scratch_pad0;
| ^
>> drivers/scsi/mpi3mr/mpi3mr_fw.c:4272:6: warning: variable 'r' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
4272 | if (!driver_pg2)
| ^~~~~~~~~~~
drivers/scsi/mpi3mr/mpi3mr_fw.c:4290:9: note: uninitialized use occurs here
4290 | return r;
| ^
drivers/scsi/mpi3mr/mpi3mr_fw.c:4272:2: note: remove the 'if' if its condition is always false
4272 | if (!driver_pg2)
| ^~~~~~~~~~~~~~~~
4273 | goto out;
| ~~~~~~~~
drivers/scsi/mpi3mr/mpi3mr_fw.c:4267:7: note: initialize the variable 'r' to silence this warning
4267 | int r;
| ^
| = 0
2 warnings generated.
--
>> Warning: drivers/scsi/mpi3mr/mpi3mr_fw.c:4262 function parameter 'sas_address' not described in 'mpi3mr_atto_get_sas_addr'
>> Warning: drivers/scsi/mpi3mr/mpi3mr_fw.c:6468 function parameter 'man_pg5' not described in 'mpi3mr_cfg_get_man_pg5'
>> Warning: drivers/scsi/mpi3mr/mpi3mr_fw.c:6468 Excess function parameter 'io_unit_pg5' description in 'mpi3mr_cfg_get_man_pg5'
>> Warning: drivers/scsi/mpi3mr/mpi3mr_fw.c:6524 function parameter 'man_pg5' not described in 'mpi3mr_cfg_set_man_pg5'
>> Warning: drivers/scsi/mpi3mr/mpi3mr_fw.c:6524 Excess function parameter 'io_unit_pg5' description in 'mpi3mr_cfg_set_man_pg5'
vim +4272 drivers/scsi/mpi3mr/mpi3mr_fw.c
4254
4255 /**
4256 * mpi3mr_atto_get_sas_addr - get the ATTO SAS address from driver page 2
4257 *
4258 * @mrioc: Adapter instance reference
4259 * @*sas_address: return sas address
4260 * Return: 0 for success, non-zero for failure.
4261 */
> 4262 static int mpi3mr_atto_get_sas_addr(struct mpi3mr_ioc *mrioc, union ATTO_SAS_ADDRESS *sas_address)
4263 {
4264 struct mpi3_driver_page2 *driver_pg2 = NULL;
4265 struct ATTO_SAS_NVRAM *nvram;
4266 u16 sz;
4267 int r;
4268 __be64 addr;
4269
4270 sz = mpi3mr_cfg_get_page_size(mrioc, MPI3_CONFIG_PAGETYPE_DRIVER, 2);
4271 driver_pg2 = kzalloc(sz, GFP_KERNEL);
> 4272 if (!driver_pg2)
4273 goto out;
4274
4275 r = mpi3mr_cfg_get_driver_pg2(mrioc, driver_pg2, sz, MPI3_CONFIG_ACTION_READ_PERSISTENT);
4276 if (r)
4277 goto out;
4278
4279 nvram = (struct ATTO_SAS_NVRAM *) &driver_pg2->trigger;
4280
4281 r = mpi3mr_atto_validate_nvram(mrioc, nvram);
4282 if (r)
4283 goto out;
4284
4285 addr = *((__be64 *) nvram->sasaddr);
4286 sas_address->q = cpu_to_le64(be64_to_cpu(addr));
4287
4288 out:
4289 kfree(driver_pg2);
4290 return r;
4291 }
4292
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki