Re: [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups

From: Jonathan Cameron
Date: Sat Jun 14 2025 - 08:08:01 EST


On Thu, 12 Jun 2025 16:07:00 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> On Wed, Jun 11, 2025 at 04:33:00PM -0500, David Lechner wrote:
> > While investigating some potential bugs, we noticed quite a few
> > opportunities for small improvements in the ada4250 driver.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> for non-commented patches. Otherwise, feel free to add it there
> if my suggestion / assumptions are wrong.
>

I think, with exception of request for pahole (which is a nice to have
to my eyes rather than a requirement) I think all addressed by David
so applied and tag picked up.

For the pahole thing only thing I can imagine it doing is showing
a less obvious additional move is useful as this one was about as
obvious as they come if IIO_DMA_MINALIGN isn't huge (in which case
it makes no difference as we have a big hole!)

Jonathan