RE: [PATCH v4 1/5] scsi: fnic: Set appropriate logging level for log message

From: Karan Tilak Kumar (kartilak)
Date: Fri Jun 13 2025 - 17:46:43 EST


On Friday, June 13, 2025 1:35 PM, John Meneghini <jmeneghi@xxxxxxxxxx> wrote:
>
> Please move this patch to the end of the series.
>
> The most important change here is:
>
> [PATCH v4 2/5] scsi: fnic: Fix crash in fnic_wq_cmpl_handler when FDMI times out
>
> This is the major fix and and it should come first. All of these other DEBUG PRINTFs are less important.
>
> Thanks,
>
> /John
>
> On 6/12/25 6:18 PM, Karan Tilak Kumar wrote:
> > Replace KERN_INFO with KERN_DEBUG for a log message.
> >
> > Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx>
> > Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx>
> > Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx>
> > Reviewed-by: Arun Easi <aeasi@xxxxxxxxx>
> > Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
> > ---
> > drivers/scsi/fnic/fnic_scsi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
> > index 7133b254cbe4..75b29a018d1f 100644
> > --- a/drivers/scsi/fnic/fnic_scsi.c
> > +++ b/drivers/scsi/fnic/fnic_scsi.c
> > @@ -1046,7 +1046,7 @@ static void fnic_fcpio_icmnd_cmpl_handler(struct fnic *fnic, unsigned int cq_ind
> > if (icmnd_cmpl->scsi_status == SAM_STAT_TASK_SET_FULL)
> > atomic64_inc(&fnic_stats->misc_stats.queue_fulls);
> >
> > - FNIC_SCSI_DBG(KERN_INFO, fnic->host, fnic->fnic_num,
> > + FNIC_SCSI_DBG(KERN_DEBUG, fnic->host, fnic->fnic_num,
> > "xfer_len: %llu", xfer_len);
> > break;
> >
>
>

Thanks for your comments, John.
Sure. I can move this to the end the series.

Regards,
Karan