Re: [PATCH v1 1/1] MIPS: Alchemy: Remove unused forward declaration

From: Thomas Bogendoerfer
Date: Fri Jun 13 2025 - 16:07:39 EST


On Fri, Jun 13, 2025 at 03:49:41PM +0300, Andy Shevchenko wrote:
> On Fri, Jun 13, 2025 at 01:31:33PM +0200, Thomas Bogendoerfer wrote:
> > On Fri, Jun 13, 2025 at 01:39:07PM +0300, Andy Shevchenko wrote:
> > > +Cc: Bart.
> > >
> > > On Sat, May 31, 2025 at 10:43:46PM +0300, Andy Shevchenko wrote:
> > > > The 'struct gpio' is not used in the code, remove unneeded forward declaration.
> > > > This seems to be a leftover for a 5 years.
> > >
> > > Any comments on this, please?
> >
> > looks good
>
> Formal tag please?
>
> > > It prevents us from moving forward with the killing the GPIO legacy APIs
> > > (it's not critical at all in this case, just an inconvenience for a `grep`,
> > > but still...).
> > >
> > > I think we can take it via GPIO tree if there is no reply.
> >
> > please do
>
> Acked-by?

Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]