Re: [PATCH v3 5/7] arm: dts: omap: Add support for BeagleBone Green Eco board

[Robert Nelson]

On Fri, Jun 13, 2025 at 10:50 AM Kory Maincent
<kory.maincent@xxxxxxxxxxx> wrote:
>
> SeeedStudio BeagleBone Green Eco (BBGE) is a clone of the BeagleBone Green
> (BBG). It has minor differences from the BBG, such as a different PMIC,
> a different Ethernet PHY, and a larger eMMC.
>
> Signed-off-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
> ---
>
> Changes in v3:
> - Move the omap.yaml binding change in another patch.
>
> Changes in v2:
> - Used generic pmic node name.
> - Add regulator prefix to fixed regulator node name.
> - Add the compatible to omap.yaml binding
> ---
>  arch/arm/boot/dts/ti/omap/Makefile                 |   1 +
>  arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts | 169 +++++++++++++++++++++
>  2 files changed, 170 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ti/omap/Makefile b/arch/arm/boot/dts/ti/omap/Makefile
> index 95c68135dd0c..1aef60eef671 100644
> --- a/arch/arm/boot/dts/ti/omap/Makefile
> +++ b/arch/arm/boot/dts/ti/omap/Makefile
> @@ -93,6 +93,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
>         am335x-boneblue.dtb \
>         am335x-bonegreen.dtb \
>         am335x-bonegreen-wireless.dtb \
> +       am335x-bonegreen-eco.dtb \
>         am335x-chiliboard.dtb \
>         am335x-cm-t335.dtb \
>         am335x-evm.dtb \
> diff --git a/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> new file mode 100644
> index 000000000000..2e6050bd2da1
> --- /dev/null
> +++ b/arch/arm/boot/dts/ti/omap/am335x-bonegreen-eco.dts
> @@ -0,0 +1,169 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2025 Bootlin
> + */
> +/dts-v1/;
> +
> +#include "am33xx.dtsi"
> +#include "am335x-bone-common.dtsi"
> +#include "am335x-bonegreen-common.dtsi"
> +#include <dt-bindings/net/ti-dp83867.h>
> +
> +/ {
> +       model = "TI AM335x BeagleBone Green Eco";
> +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";

Based on [2/7] ARM: dts: omap: Remove incorrect compatible strings
from device trees  this should be???

> +       model = "Seeed AM335x BeagleBone Green Eco";
> +       compatible = "seeed,am335x-bone-green-eco", "ti,am33xx";

I feel bad as I'm the one who wrote most of these wrong in the first
place that you are claning up for me!

Regards,

-- 
Robert Nelson
https://rcn-ee.com/