Re: [PATCH v2 1/3] rust: completion: implement initial abstraction
From: Miguel Ojeda
Date: Fri Jun 13 2025 - 11:54:48 EST
On Thu, Jun 12, 2025 at 2:18 PM Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>
> Implement a minimal abstraction for the completion synchronization
> primitive.
>
> This initial abstraction only adds complete_all() and
> wait_for_completion(), since that is what is required for the subsequent
> Devres patch.
>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Vincent Guittot <vincent.guittot@xxxxxxxxxx>
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Ben Segall <bsegall@xxxxxxxxxx>
> Cc: Mel Gorman <mgorman@xxxxxxx>
> Cc: Valentin Schneider <vschneid@xxxxxxxxxx>
> Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> Reviewed-by: Boqun Feng <boqun.feng@xxxxxxxxx>
> Reviewed-by: Benno Lossin <lossin@xxxxxxxxxx>
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
This is part of a fix, so it is a bit of an edge case, but it is just
the bits Danilo needs, so as long as nobody in the Cc list above
complains:
Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> +/// The [`Completion`] synchronization primitive signales when a certain task has been completed by
signals
Cheers,
Miguel