Re: [PATCH v3 10/62] KVM: SVM: Add helper to deduplicate code for getting AVIC backing page

From: Naveen N Rao
Date: Fri Jun 13 2025 - 10:41:18 EST


On Wed, Jun 11, 2025 at 03:45:13PM -0700, Sean Christopherson wrote:
> Add a helper to get the physical address of the AVIC backing page, both
> to deduplicate code and to prepare for getting the address directly from
> apic->regs, at which point it won't be all that obvious that the address
> in question is what SVM calls the AVIC backing page.
>
> No functional change intended.
>
> Reviewed-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
> Tested-by: Sairaj Kodilkar <sarunkod@xxxxxxx>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> ---
> arch/x86/kvm/svm/avic.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)

LGTM.
Reviewed-by: Naveen N Rao (AMD) <naveen@xxxxxxxxxx>

- Naveen