Re: [PATCH RFC 1/3] dt-bindings: soc: sophgo: add TOP syscon for CV18XX/SG200X series SoC

[Conor Dooley]

On Fri, Jun 13, 2025 at 06:09:47AM +0800, Inochi Amaoto wrote:
> On Thu, Jun 12, 2025 at 05:04:46PM +0100, Conor Dooley wrote:
> > On Wed, Jun 11, 2025 at 04:24:49PM +0800, Inochi Amaoto wrote:
> > > The Sophgo CV1800/SG2000 SoC top misc system controller provides register
> > > access to configure related modules. It includes a usb2 phy and a dma
> > > multiplexer.
> > > 
> > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx>
> > > ---
> > >  .../soc/sophgo/sophgo,cv1800b-top-syscon.yaml | 57 +++++++++++++++++++
> > >  1 file changed, 57 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-top-syscon.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-top-syscon.yaml b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-top-syscon.yaml
> > > new file mode 100644
> > > index 000000000000..e8093a558c4e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-top-syscon.yaml
> > > @@ -0,0 +1,57 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/soc/sophgo/sophgo,cv1800b-top-syscon.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Sophgo CV18XX/SG200X SoC top system controller
> > > +
> > > +maintainers:
> > > +  - Inochi Amaoto <inochiama@xxxxxxxxxxx>
> > > +
> > > +description:
> > > +  The Sophgo CV18XX/SG200X SoC top misc system controller provides
> > > +  register access to configure related modules.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> > > +      - items:
> > > +          - const: sophgo,cv1800b-top-syscon
> > > +          - const: syscon
> > > +          - const: simple-mfd
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  "#address-cells":
> > > +    const: 1
> > > +
> > > +  "#size-cells":
> > > +    const: 1
> > > +
> > > +patternProperties:
> > > +  "dma-router@[0-9a-f]+$":
> > > +    $ref: /schemas/dma/sophgo,cv1800b-dmamux.yaml#
> > 
> > I think you're supposed to add "unevaluatedProperties: false" to each of
> > these nodes.
> > 
> 
> This is is OK for me.
> 
> > > +
> > > +  "phy@[0-9a-f]+$":
> > > +    $ref: /schemas/phy/sophgo,cv1800b-usb2-phy.yaml#
> > 
> > Why are these permitting random addresses? Are they not at fixed
> > addreses given that you only support one platform (modulo the rebrand)?
> > 
> 
> IIRC, they are fixed address. I use random addresses as I see many one
> in binding do the same. Should I switch to the fixed one?

If things are actually possible to have at variable addresses, then sure
use pattern properties and a regex. It may be like that if a new device
is released that reuses the dmamux or phy but locates it differently or
on a platform with multiple phys etc. If not, then then just restrict the
address to the only permitted one.

Attachment: signature.asc
Description: PGP signature