Re: [PATCH 6/8] arm64: dts: renesas: Refactor RZ/T2H EVK device tree

From: Lad, Prabhakar
Date: Fri Jun 13 2025 - 08:30:38 EST


Hi Geert,

Thank you for the review.

On Thu, Jun 12, 2025 at 3:47 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Mon, 9 Jun 2025 at 22:37, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>
> >
> > The RZ/T2H EVK and RZ/N2H EVK are very similar boards. As there is so
> > much overlap between these parts, common device tree entries are moved
> > to the new file rzt2h-evk-common.dtsi.
> >
> > Signed-off-by: Paul Barker <paul.barker.ct@xxxxxxxxxxxxxx>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > .../dts/renesas/r9a09g077m44-rzt2h-evk.dts | 17 +------------
>
> Definitely a good idea! Note that r9a09g077m44-rzt2h-evk.dts does not
> exist yet in my tree...
>
Yep I have based my patches on top of v10, are we waiting for the
serial driver to be merged in first?

> > .../boot/dts/renesas/rzt2h-evk-common.dtsi | 24 +++++++++++++++++++
> > 2 files changed, 25 insertions(+), 16 deletions(-)
> > create mode 100644 arch/arm64/boot/dts/renesas/rzt2h-evk-common.dtsi
>
> Perhaps call it rzt2h-n2h-evk-common.dtsi, to match the filename
> of the documentation?
>
Agreed, I will rename it. (Note although there are similarities, the
DIP switch settings differ quite a lot. So If you prefer Im OK to go
either ways)

Cheers,
Prabhakar