Re: [PATCH net-next 4/4] net: mana: Handle unsupported HWC commands

[Erni Sri Satya Vennela]

On Wed, Jun 11, 2025 at 04:35:39AM -0700, Dipayaan Roy wrote:
> On Wed, Jun 11, 2025 at 01:46:16AM -0700, Erni Sri Satya Vennela wrote:
> > If any of the HWC commands are not recognized by the
> > underlying hardware, the hardware returns the response
> > header status of -1. Log the information using
> > netdev_info_once to avoid multiple error logs in dmesg.
> > 
> > Signed-off-by: Erni Sri Satya Vennela <ernis@xxxxxxxxxxxxxxxxxxx>
> > Reviewed-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> > Reviewed-by: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/net/ethernet/microsoft/mana/hw_channel.c |  4 ++++
> >  drivers/net/ethernet/microsoft/mana/mana_en.c    | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> > 
> > diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > index a8c4d8db75a5..70c3b57b1e75 100644
> > --- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > +++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
> > @@ -890,6 +890,10 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> >  	}
> >  
> >  	if (ctx->status_code && ctx->status_code != GDMA_STATUS_MORE_ENTRIES) {
> > +		if (ctx->status_code == -1) {
> Minor comment: instead of == -1 could use some macro like GDMA_STATUS_CMD_UNSUPPORTED, rest LGTM.
Thankyou Dipayaan.
I'll define this macro and us it for the next version.
> 
> Reviewed-by: Dipayaan Roy <dipayanroy@xxxxxxxxxxxxxxxxxxx>