Re: [PATCH] gpio: spacemit: Add missing MODULE_DEVICE_TABLE

From: Yixun Lan
Date: Fri Jun 13 2025 - 05:35:17 EST


Hi Vivian,

On 17:25 Fri 13 Jun , Vivian Wang wrote:
> The gpio-spacemit-k1 driver can be compiled as a module. Add missing
> MODULE_DEVICE_TABLE so it can be matched by modalias and automatically
> loaded by udev.
>
> Fixes: d00553240ef8 ("gpio: spacemit: add support for K1 SoC")
> Signed-off-by: Vivian Wang <wangruikang@xxxxxxxxxxx>
LGTM

Reviewed-by: Yixun Lan <dlan@xxxxxxxxxx>

> ---
> This patch is available at:
>
> https://github.com/dramforever/linux/tree/k1/gpio-of-table/v1
> ---
> drivers/gpio/gpio-spacemit-k1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-spacemit-k1.c b/drivers/gpio/gpio-spacemit-k1.c
> index f027066365ff8741f99da076d1e7b6339a6c1a22..3cc75c701ec40194e602b80d3f96f23204ce3b4d 100644
> --- a/drivers/gpio/gpio-spacemit-k1.c
> +++ b/drivers/gpio/gpio-spacemit-k1.c
> @@ -278,6 +278,7 @@ static const struct of_device_id spacemit_gpio_dt_ids[] = {
> { .compatible = "spacemit,k1-gpio" },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, spacemit_gpio_dt_ids);
>
> static struct platform_driver spacemit_gpio_driver = {
> .probe = spacemit_gpio_probe,
>
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250613-k1-gpio-of-table-222b4b76b453
>
> Best regards,
> --
> Vivian "dramforever" Wang
>

--
Yixun Lan (dlan)