Re: [PATCH V2] net: usb: Convert tasklet API to new bottom half workqueue mechanism

[Subbaraya Sundeep]

On 2025-06-13 at 01:51:31, Jakub Kicinski (kuba@xxxxxxxxxx) wrote:
> On Tue, 10 Jun 2025 22:54:03 +0800 Jun Miao wrote:
> > -			if (rx_alloc_submit(dev, GFP_ATOMIC) == -ENOLINK)
> > +			if (rx_alloc_submit(dev, GFP_NOIO) == -ENOLINK)
> 
> Sorry, I think Subbaraya mislead you. v1 was fine.
> If we want to change the flags (which Im not sure is correct) it should
> be a separate commit. Could you repost v1? There is no need to attribute
Yeah hence asked to correct me if wrong.
GFP_ATOMIC has to be there - "this patchset implements BH workqueues
which are like regular workqueues but executes work items in the BH
(softirq) context" from:
https://lwn.net/Articles/960020/

Thanks,
Sundeep
> reviewers with Suggested-by tags. They can send their review tags if
> they so wish.
> -- 
> pw-bot: cr