Re: [PATCH v8 0/9] More Rust bindings for device property reads

[Danilo Krummrich]

On Fri, Jun 13, 2025 at 09:45:47AM +0200, Remo Senekowitsch wrote:
> On Fri Jun 13, 2025 at 1:31 AM CEST, Danilo Krummrich wrote:
> > On Wed, Jun 11, 2025 at 12:28:59PM +0200, Remo Senekowitsch wrote:
> >> Remo Senekowitsch (9):
> >>   rust: device: Create FwNode abstraction for accessing device
> >>     properties
> >>   rust: device: Enable accessing the FwNode of a Device
> >>   rust: device: Move property_present() to FwNode
> >>   rust: device: Enable printing fwnode name and path
> >>   rust: device: Introduce PropertyGuard
> >>   rust: device: Implement accessors for firmware properties
> >>   samples: rust: platform: Add property read examples
> >
> > Applied to driver-core-testing, thanks!
> >
> > Once the patches passed 0-day testing they will be merged into driver-core-next.
> >
> >>   rust: device: Add child accessor and iterator
> >>   rust: device: Add property_get_reference_args
> >
> > I did drop those two patches for now, because:
> >
> >   (1) They're basically dead code.
> >
> >   (2) It seems that FwNode::property_get_reference_args() leaks a struct
> >       fwnode_handle reference. property_get_reference_args() explicitly says
> >       that the caller is responsible "for calling fwnode_handle_put() on the
> >       returned @args->fwnode pointer", which doesn't seem to happen.
> >
> > Can you please fix the leak and resend those two patches with an additional one
> > that adds a sample usage of the introduced methods to the platform sample
> > driver?
> 
> Alright, thanks. I suppose that should be a new patch series, with a new
> title and starting at v1 ..?

Yes, that's fine. Please make sure to mention that it's a follow-up of this
series (ideally with a link).