Re: [PATCH v4 1/2] iio: imu: inv_icm42600: add WoM support
From: Andy Shevchenko
Date: Fri Jun 13 2025 - 04:31:08 EST
On Fri, Jun 13, 2025 at 09:34:26AM +0200, Jean-Baptiste Maneyrol via B4 Relay wrote:
>
> Add WoM as accel roc rising x|y|z event.
...
> + if (sleep_ms)
> + msleep(sleep_ms);
I still wonder if we can get rid of the conditional here.
Would the
fsleep(sleep_ms * USEC_PER_MSEC)
actually work as expected?
Ditto for other case(s) like this.
...
Overall, looking to this patch again, I think it would be better to prepend it
by replacing *int*_t types by the respective uXX ones. Because in this patch
we add dozens of new ones which increases an unneeded churn in the future.
--
With Best Regards,
Andy Shevchenko