Re: [PATCH v4 2/4] media: qcom: camss: Add support for MSM8939

[Bryan O'Donoghue]

On 07/06/2025 22:43, Vincent Knecht wrote:
> Le vendredi 06 juin 2025 à 13:59 +0300, Vladimir Zapolskiy a écrit :
> > Hello Vincent.
> >
> > On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote:
> > > From: Vincent Knecht <vincent.knecht@xxxxxxxxxx>
> > >
> > > The camera subsystem for the MSM8939 is the same as MSM8916 except with
> > > 3 CSID instead of 2, and some higher clock rates.
> > >
> > > As a quirk, this SoC needs writing values to 2 VFE VBIF registers
> > > (see downstream msm8939-camera.dtsi vbif-{regs,settings} properties).
> > > This fixes black stripes across sensor and garbage in CSID TPG outputs.
> > >
> > > Add support for the MSM8939 camera subsystem.
> > >
> > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> > > Signed-off-by: Vincent Knecht <vincent.knecht@xxxxxxxxxx>
> >
> > There was a preceding and partially reviewed changeset published on
> > linux-media [1] before v1 of the MSM8939 platform support in CAMSS,
> > due to a merge conflict this platform changeset should be rebased IMHO.
> >
> > [1] https://lore.kernel.org/all/20250513142353.2572563-4-vladimir.zapolskiy@xxxxxxxxxx/
> >
> > --
> > Best wishes,
> > Vladimir
>
> Thank you, I'll look into it

I think I will take 8939, plus any of the other now 3 SoCs waiting to be 
merged with RBs.

Bindings consistent with the last 10 years can go ahead. Its not 
reasonable or in the interests of the community and developers to gate 
any further.

---
bod