Re: [PATCH v4 1/1] ARM: dts: aspeed: Add device tree for Nvidia's GB200 UT3.0b platform BMC

[Andrew Jeffery]

On Thu, 2025-06-12 at 16:59 +0000, Donald Shannon wrote:
> Hi Andrew and Krzysztof,
> 
> The difference in this device tree is adding more GPIO expanders and
> changing the networking.

Can you please include a description of these differences in the commit
message?

> 
> Would it be best practice to create a new device binding (in this
> case nvidia,gb200-ut30b), even if it is just a slight modification on
> gb200nvl-bmc? Or can I reuse the gb200nvl-bmc compatible string and
> avoid the yaml binding change all together since it would share the
> same drivers?

You can include the aspeed-bmc-nvidia-gb200nvl-bmc.dts file and
override the nodes where the differences lie if that helps. There are
existing examples of this strategy, for instance:

   $ git grep '^#include .*\.dts"$' arch/arm/boot/dts/aspeed/
   arch/arm/boot/dts/aspeed/aspeed-ast2600-evb-a1.dts:#include "aspeed-ast2600-evb.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge-4u.dts:#include "aspeed-bmc-ibm-blueridge.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-1s4u.dts:#include "aspeed-bmc-ibm-rainier-4u.dts"
   arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier-4u.dts:#include "aspeed-bmc-ibm-rainier.dts"

Whether or not the differences warrant a separate compatible - I'm not
sure.

Andrew