RE: [PATCH] HID: intel-thc-hid: Separate max input size control conditional list

From: Xu, Even
Date: Thu Jun 12 2025 - 23:08:07 EST


Thanks for the fix, Bagas!

Best Regards,
Even Xu

> -----Original Message-----
> From: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
> Sent: Friday, June 13, 2025 9:43 AM
> To: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; Linux
> Documentation <linux-doc@xxxxxxxxxxxxxxx>; Linux Input Devices <linux-
> input@xxxxxxxxxxxxxxx>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>;
> Jonathan Corbet <corbet@xxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; Xu, Even <even.xu@xxxxxxxxx>; Han,
> Chong <chong.han@xxxxxxxxx>; Bagas Sanjaya <bagasdotme@xxxxxxxxx>;
> Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Subject: [PATCH] HID: intel-thc-hid: Separate max input size control conditional
> list
>
> Stephen Rothwell reports htmldocs warning:
>
> Documentation/hid/intel-thc-hid.rst:200: ERROR: Unexpected indentation.
> [docutils]
>
> Separate conditional list for max input size control by a blank line to fix the
> warning.
>
> Fixes: 45e92a093099 ("HID: Intel-thc-hid: Intel-thc: Introduce max input size
> control")
> Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/linux-
> next/20250611142409.7d4683b0@xxxxxxxxxxxxxxxx/
> Signed-off-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx>
> ---
> Documentation/hid/intel-thc-hid.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/hid/intel-thc-hid.rst b/Documentation/hid/intel-thc-
> hid.rst
> index 23d5110cb8710a..8b378c57b5aac0 100644
> --- a/Documentation/hid/intel-thc-hid.rst
> +++ b/Documentation/hid/intel-thc-hid.rst
> @@ -195,6 +195,7 @@ This is a new feature introduced in Panther Lake
> platform, THC hardware allows d a max input size for RxDMA. After this max size
> gets set and enabled, for every input report packet reading, THC hardware
> sequencer will first read incoming input packet size, then compare input packet
> size with the given max size:
> +
> - if input packet size <= max size, THC continues using input packet size to finish
> the reading
> - if input packet size > max size, there is potential input data crash risk during
> transferring, THC will use max size instead of input packet size for reading
>
> base-commit: da04eb7791c461bc0f113ce96af4ed59bcc12555
> --

Reviewed-by: Even Xu <even.xu@xxxxxxxxx>

> An old man doll... just what I always wanted! - Clara