Re: [PATCH 1/2] VFS: change old_dir and new_dir in struct renamedata to dentrys

[Namjae Jeon]

On Thu, Jun 12, 2025 at 7:59 AM NeilBrown <neil@xxxxxxxxxx> wrote:
>
> all users of 'struct renamedata' have the dentry for the old and new
> directories, and often have no use for the inode except to store it in
> the renamedata.
>
> This patch changes struct renamedata to hold the dentry, rather than
> the inode, for the old and new directories, and changes callers to
> match.
>
> This results in the removal of several local variables and several
> dereferences of ->d_inode at the cost of adding ->d_inode dereferences
> to vfs_rename().
>
> Signed-off-by: NeilBrown <neil@xxxxxxxxxx>
For ksmbd part,
Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
Thanks!