Re: [PATCH v1 3/3] firmware: coreboot: Linux-owned SMI handler to be loaded by coreboot

[Brian Norris]

On Thu, Jun 12, 2025 at 04:05:50PM +0200, Michal Gorlas wrote:
> Compiled in similar fashion to the realmode trampolines for x86. Currently
> supported are two SMIs: ACPI enable and disable. After being placed in SMRAM,
> this handler takes over handling of the supported SMIs from coreboot.
> 
> Signed-off-by: Michal Gorlas <michal.gorlas@xxxxxxxxxxxxx>
> ---
>  drivers/firmware/google/mm_handler/Makefile   |  51 ++
>  .../firmware/google/mm_handler/handler.lds.S  |  46 ++
>  .../firmware/google/mm_handler/mm_handler.S   | 510 ++++++++++++++++++
>  .../firmware/google/mm_handler/mm_handler.h   |  21 +
>  .../firmware/google/mm_handler/mm_header.S    |  19 +
>  5 files changed, 647 insertions(+)
>  create mode 100644 drivers/firmware/google/mm_handler/Makefile
>  create mode 100644 drivers/firmware/google/mm_handler/handler.lds.S
>  create mode 100644 drivers/firmware/google/mm_handler/mm_handler.S
>  create mode 100644 drivers/firmware/google/mm_handler/mm_handler.h
>  create mode 100644 drivers/firmware/google/mm_handler/mm_header.S

I'm not reviewing most of this patch right now (for one, I don't speak
x86), but for starters, I think you need to add a .gitignore file in
here somewhere. After building your code, I see these untracked files:

	drivers/firmware/google/mm_handler/handler.lds
	drivers/firmware/google/mm_handler/handler.relocs
	drivers/firmware/google/mm_handler/pasyms.h

Brian