Re: [PATCH net-next v2 2/2] net: bcmasp: enable GRO software interrupt coalescing by default

[Joe Damato]

On Wed, Jun 11, 2025 at 02:27:30PM -0700, Florian Fainelli wrote:
> Utilize netdev_sw_irq_coalesce_default_on() to provide conservative
> default settings for GRO software interrupt coalescing.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Reviewed-by: Justin Chen <justin.chen@xxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> index 7dc28166d337..a6ea477bce3c 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
> @@ -1279,6 +1279,8 @@ struct bcmasp_intf *bcmasp_interface_create(struct bcmasp_priv *priv,
>  	ndev->hw_features |= ndev->features;
>  	ndev->needed_headroom += sizeof(struct bcmasp_pkt_offload);
>  
> +	netdev_sw_irq_coalesce_default_on(ndev);
> +
>  	return intf;

Just to make it explicit to other readers: netdev_sw_irq_coalesce_default_on
appears to be called before register_netdev, as the documentation for
netdev_sw_irq_coalesce_default_on describes.

Reviewed-by: Joe Damato <joe@xxxxxxx>