Re: [PATCH net-next v02 1/1] hinic3: management interfaces

[Jakub Kicinski]

On Thu, 12 Jun 2025 17:28:29 +0800 Fan Gong wrote:
> +	if (!atomic_dec_and_test(&cmd_buf->ref_cnt))
> +		return;

you should use refcount.h for object reference counting

> +	cmdqs = hwdev->cmdqs;
> +
> +	dma_pool_free(cmdqs->cmd_buf_pool, cmd_buf->buf, cmd_buf->dma_addr);
> +	kfree(cmd_buf);
-- 
pw-bot: cr