Re: [PATCH v3 4/5] iio: amplifiers: ada4250: move offset_uv in struct

From: Andy Shevchenko
Date: Thu Jun 12 2025 - 14:34:53 EST


On Thu, Jun 12, 2025 at 6:31 PM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
> On 6/12/25 8:04 AM, Andy Shevchenko wrote:
> > On Wed, Jun 11, 2025 at 04:33:04PM -0500, David Lechner wrote:
> >> Move offset_uv in struct ada4250_state. This keeps things logically
> >> grouped and reduces holes in the struct.
> >
> > Can the (smallest part of) the diff for `pahole` runs be added here?
>
> Well, I didn't use pahole. I could just tell by looking at it. There
> was int followed by two u8 followed by int, so we know there was a 2
> byte hole before the last int.

Yes, but since we have a tool for such cases, why not use it?

--
With Best Regards,
Andy Shevchenko