Re: [PATCH] xfs: actually use the xfs_growfs_check_rtgeom tracepoint

From: Steven Rostedt
Date: Thu Jun 12 2025 - 14:01:02 EST


On Thu, 12 Jun 2025 10:51:12 -0700
"Darrick J. Wong" <djwong@xxxxxxxxxx> wrote:

> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> We created a new tracepoint but forgot to put it in. Fix that.
>
> Cc: rostedt@xxxxxxxxxxx
> Cc: <stable@xxxxxxxxxxxxxxx> # v6.14
> Fixes: 59a57acbce282d ("xfs: check that the rtrmapbt maxlevels doesn't increase when growing fs")

May want to also add:

Reported-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
Closes: https://lore.kernel.org/all/20250612131021.114e6ec8@xxxxxxxxxxxxxxxxx/

Thanks,

-- Steve

> Signed-off-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> ---
> fs/xfs/xfs_rtalloc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 6484c596eceaf2..736eb0924573d3 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -1259,6 +1259,8 @@ xfs_growfs_check_rtgeom(
>
> kfree(nmp);
>
> + trace_xfs_growfs_check_rtgeom(mp, min_logfsbs);
> +
> if (min_logfsbs > mp->m_sb.sb_logblocks)
> return -EINVAL;
>