Re: Unused event xfs_growfs_check_rtgeom
From: Darrick J. Wong
Date: Thu Jun 12 2025 - 13:48:07 EST
On Thu, Jun 12, 2025 at 01:10:21PM -0400, Steven Rostedt wrote:
> I have code that will cause a warning if a trace event or tracepoint is
> created but not used. Trace events can take up to 5K of memory in text
> and meta data per event. There's a lot of events in the XFS file system
> that are not used, but one in particular was added by commit
> 59a57acbce282 ("xfs: check that the rtrmapbt maxlevels doesn't increase
> when growing fs"). That event is xfs_growfs_check_rtgeom, but it was
> never called.
>
> It looks like it was just an oversight. I'm holding off from deleting
> it as it may still be valid but just never been added. It was added
> relatively recently.
Yes that's a bug. Will send a fix shortly.
--D
> -- Steve